Open
Conversation
anhu
reviewed
Jul 31, 2025
Comment on lines
+1360
to
+1361
| test "$enable_lms" = "" && enable_lms='yes,sha256-192' | ||
| test "$enable_xmss" = "" && enable_xmss=yes |
anhu
reviewed
Jul 31, 2025
configure.ac
Outdated
Comment on lines
1363
to
1366
| if test "$ENABLED_EXPERIMENTAL" = "yes" | ||
| then | ||
| test "$enable_dilithium" = "" && enable_dilithium=yes | ||
| fi |
Member
There was a problem hiding this comment.
I think nothing should be experimental after not being experimental? Customers will think its weird.
Contributor
Author
There was a problem hiding this comment.
Per SPH, the alternative was leaving it out of all-crypto entirely for now, but I'm game for just enabling it here without the experimental gate.
Member
There was a problem hiding this comment.
I mean, when you do ./configure --enable-dilithium it works. So, should not need an experimental gate.
Contributor
Author
|
This PR has uncovered some substantive stuff -- mainly the RISC-V build failure, but there's also some |
SparkiDev
previously approved these changes
Jul 31, 2025
…and by extension, --enable-all).
…for ENABLED_EXPERIMENTAL; wolfssl/wolfcrypt/sha512.h: add a prototype for wc_Sha512HashBlock() (only implemented in wolfcrypt/src/port/riscv/riscv-64-sha512.c); wolfcrypt/src/asn.c, wolfcrypt/src/wc_mlkem.c, wolfcrypt/src/wc_mlkem_poly.c: add casts (and fix a few type clashes) to suppress for -Wconversions.
douzzer
force-pushed
the
20250731-enable-all-crypto-PQC
branch
from
67ee52e to
80200c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.ac: add native PQC implementations to--enable-all-crypto(and by extension,--enable-all).tested with
wolfssl-multi-test.sh ... check-source-text check-configureand a couple direct builds with and without linuxkm.note, Dilithium gated behind
$ENABLED_EXPERIMENTALuntil name conversion to ML-DSA.